https://useinov.com/tags/static-analysis/ Recent content in Static-Analysis on Murat Useinov Hugo en-us Sat, 09 Sep 2017 15:30:00 +0300 https://useinov.com/posts/2017/phpstan-first-run/ Sat, 09 Sep 2017 15:30:00 +0300 https://useinov.com/posts/2017/phpstan-first-run/ <p>Level 0, a legacy codebase, a few hundred errors on the first run. That was my week with PHPStan. Most of the output was noise about magic the tool cannot see. But in the first hour of reading I found three real bugs, live in production for months.</p> <p>One: a repository method returns an entity or null, and a caller chains a method right on the result. The not-found branch was never written. It survived because that path needs a deleted record, and deleted records are rare. Rare is not never.</p>